Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blame): add verbose render style #1099

Closed
wants to merge 4 commits into from

Conversation

iamxiaojianzheng
Copy link

image

image

@lewis6991
Copy link
Owner

lewis6991 commented Jul 25, 2024

What is the point of this? Posting screenshots isn't enough.

@iamxiaojianzheng
Copy link
Author

iamxiaojianzheng commented Jul 25, 2024

What is the point of this?

Compared with the original default, this might be more suitable for reading. The previous style had the situation of dislocation.

I think it is not very intuitive.

@iamxiaojianzheng
Copy link
Author

This is an alternative and does not change the default behavior.

You can switch to this style using parameter control.

Gitsigns blame 'verbose'

@lewis6991
Copy link
Owner

Default behaviour of what?

@iamxiaojianzheng
Copy link
Author

The difference looks something like this

image image

@iamxiaojianzheng
Copy link
Author

iamxiaojianzheng commented Jul 25, 2024

I refer to the display effect of idea, and I feel that this will indeed be more intuitive.

image

The original way, I think it's a bit of a waste of effort to guess the range of gaps.

image

@lewis6991
Copy link
Owner

lewis6991 commented Jul 25, 2024

Sorry but I don't want to maintain this, so I think I'll pass.

The current behaviour matches what Github does.

image

@iamxiaojianzheng
Copy link
Author

Sorry but I don't want to maintain this, so I think I'll pass.对不起,但我不想保持这个,所以我想我会过去的。

The current behaviour matches what Github does.当前的行为与 Github 的行为相匹配。

image

I agree with this style, but can neovim support it better now?

@iamxiaojianzheng
Copy link
Author

These thick dotted lines feel very affecting reading. After using it for a while, it was a little hard to accept.

image

@lewis6991
Copy link
Owner

Those are defined by your config. Try:

vim.opt.fillchars:append { diff = ' ' }

@iamxiaojianzheng
Copy link
Author

Those are defined by your config. Try:

vim.opt.fillchars:append { diff = ' ' }

The current display problem is not the character, but the height. No matter what character is changed, even if it is blank, the final effect will interfere with reading.

@iamxiaojianzheng
Copy link
Author

Sorry but I don't want to maintain this, so I think I'll pass.

The current behaviour matches what Github does.

image

The final effect is also very different from that in the picture.

@lewis6991
Copy link
Owner

lewis6991 commented Jul 25, 2024

Looks close enough to me:

image

One is in a terminal, and the other is in a gui. What changes would you suggest to make it better?

@iamxiaojianzheng
Copy link
Author

Looks close enough to me:看起来离我很近:

image

One is in a terminal, and the other is in a gui. What changes would you suggest to make it better?一个在终端中,另一个在 gui 中。你建议做出哪些改变来让它变得更好?

Looks close enough to me:

image

One is in a terminal, and the other is in a gui. What changes would you suggest to make it better?

Haha, it doesn't matter what style it is. Just get used to it.

@lewis6991 lewis6991 closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants