-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detection of active runtime version manager fails #440
Comments
Out of curiosity, how are you starting VS Code? Do you start it using |
Also, to test a theory, would you mind adding the rtx activation to
|
VS Code is running on Windows and remotely connecting to the linux computer with the source
but I don't know the detection logic you implemented but perhaps it should respect the active shell? |
Yep, I use the same setup. However, could you clarify whether VS Code is started using Could you also please clarify the behavior if you do not initialize asdf in your bashrc and only initialize rtx? |
I'm starting VS Code from an icon on my windows taskbar. I'm using zsh, but despite of that: in both files (
Please don't spend to much time on this edge case |
Did some investigation over the weekend. I don't have a fix yet. I was able to reproduce the issue by installing rtx and setting up rtx as described. I can only reproduce by starting VS Code from the Windows Start Menu and ensuring that any existing "sessions" have been closed (Close Remote Connection) and then restarted. Otherwise, VS Code seems to inherit whatever environment was previously set when I started the editor using I still don't understand why the connection fails after Lexical starts from asdf. Even though it should optimally use rtx, it finds a compatible version through asdf and that should be sufficient to start. This should be the next point of investigation. @Terbium-135 A couple more questions:
|
The checks in `activate_version_manager.sh` need explicit `{ }` to prevent `_detect_rtx` from always running. This would cause the script to exit with an error spuriously, which would trigger an error message that was being written to stdio. Because we use stdio as our transport, that would cause the LS client to crash. This fixes the crash reported in #440. However, it will still run the server using asdf if both asdf and rtx are installed with the correct versions of Elixir.
The checks in `activate_version_manager.sh` need explicit `{ }` to prevent `_detect_rtx` from always running. This would cause the script to exit with an error spuriously, which would trigger an error message that was being written to stdio. Because we use stdio as our transport, that would cause the LS client to crash. This fixes the crash reported in #440. However, it will still run the server using asdf if both asdf and rtx are installed with the correct versions of Elixir.
Should be fixed on main and in the 0.4.0 release! |
Checked out lexical main up to:
I am unable to start lexical (editor is
vscode
here):I have both runtime managers installed
asdf
as well asrtx
but only rtx is activated in.zshrc
:After manually hiding the
.asdf
folder lexical starts normalLet me know if further information is needed
The text was updated successfully, but these errors were encountered: