Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asdf): change order of installation #186

Merged
merged 1 commit into from
May 27, 2023
Merged

Conversation

03juan
Copy link
Contributor

@03juan 03juan commented May 26, 2023

If a user has set up a ~/.default-mix-commands file such as mine:

local.hex
local.rebar
archive.install hex phx_new
archive.install hex nerves_bootstrap

then running $ asdf install will fail if the specified erlang version is not installed:

Running mix local.hex --force...
No preset version installed for command erl
Please install a version by running one of the following:

asdf install erlang 25.2.1

or add one of the following versions in your config file at /home/juan/code/forks/GitHub/lexical/.tool-versions
erlang 26.0

Running mix local.rebar --force...
No preset version installed for command erl
Please install a version by running one of the following:

asdf install erlang 25.2.1

or add one of the following versions in your config file at /home/juan/code/forks/GitHub/lexical/.tool-versions
erlang 26.0

Running mix archive.install hex phx_new --force...
No preset version installed for command erl
Please install a version by running one of the following:

asdf install erlang 25.2.1

or add one of the following versions in your config file at /home/juan/code/forks/GitHub/lexical/.tool-versions
erlang 26.0

Running mix archive.install hex nerves_bootstrap --force...
No preset version installed for command erl
Please install a version by running one of the following:

asdf install erlang 25.2.1

or add one of the following versions in your config file at /home/juan/code/forks/GitHub/lexical/.tool-versions
erlang 26.0

Swapping the order fixes this issue.

If a user has set up a `~/.default-mix-commands` file such as mine:

```
local.hex
local.rebar
archive.install hex phx_new
archive.install hex nerves_bootstrap
```

then running `$ asdf install` will fail if the specified erlang version is not installed:

```sh
Running mix local.hex --force...
No preset version installed for command erl
Please install a version by running one of the following:

asdf install erlang 25.2.1

or add one of the following versions in your config file at /home/juan/code/forks/GitHub/lexical/.tool-versions
erlang 26.0

Running mix local.rebar --force...
No preset version installed for command erl
Please install a version by running one of the following:

asdf install erlang 25.2.1

or add one of the following versions in your config file at /home/juan/code/forks/GitHub/lexical/.tool-versions
erlang 26.0

Running mix archive.install hex phx_new --force...
No preset version installed for command erl
Please install a version by running one of the following:

asdf install erlang 25.2.1

or add one of the following versions in your config file at /home/juan/code/forks/GitHub/lexical/.tool-versions
erlang 26.0

Running mix archive.install hex nerves_bootstrap --force...
No preset version installed for command erl
Please install a version by running one of the following:

asdf install erlang 25.2.1

or add one of the following versions in your config file at /home/juan/code/forks/GitHub/lexical/.tool-versions
erlang 26.0
```

Swapping the order fixes this issue.
@03juan 03juan changed the title fix(tools): change order of installation fix(asdf): change order of installation May 26, 2023
@scohen scohen merged commit 655ee5b into lexical-lsp:main May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants