Improve UX when completing struct #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR also includes another fix, which is that functions or macros with arity 0 should not appear in the autocomplete of pipelines.
…e-ux-when-completing-single-module
scottming
commented
May 30, 2023
I gave you an example of where fuzzy search comes in handy. Providing a different example where you don't think it's handy doesn't make your case. I think it's important, and we already have it for other types of completions. I've looked at this, and it's pretty complicated for what you get. Let's not focus on documentation right now, as that's the lion's share of the complexity here. |
scohen
reviewed
May 30, 2023
apps/remote_control/lib/lexical/remote_control/completion/struct.ex
Outdated
Show resolved
Hide resolved
apps/server/lib/lexical/server/code_intelligence/completion/translations/module_or_behaviour.ex
Outdated
Show resolved
Hide resolved
apps/remote_control/lib/lexical/remote_control/completion/struct.ex
Outdated
Show resolved
Hide resolved
scottming
changed the base branch from
fix-remote-function-completion-in-pipeline
to
main
scohen
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the first part of #182
This PR has two improvements:
The first one is related to 182 issues. Additionally, I don't think we need fuzzy search. For example, if the target is
%Document.Lines{}, without fuzzy search, we can simply type%Docand then press enter or tab for auto-completion. More options will appear automatically and we can filter by typingl. With fuzzy search, maybe we could complete it by typing %Docl, but you need to remember that this module exists in advance. I don't think this experience is good. The current way is already very convenient for me.The second improvement adds structure documentation, including fields, types and default values. I really like this UI but I'm unsure if you guys like the code implementation too. I'd like to hear your opinions first before adding more tests.CleanShot.2023-05-29.at.15.23.59.mp4