Centralize general-use AST modules in common
#342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scohen
approved these changes
Aug 22, 2023
scottming
approved these changes
Aug 22, 2023
Completions are currently built on top of two behaviours, `Environment` and `Builder`. The first describes a behaviour for inspecting the contextual environment of a given position so that you can filter completions to only those that would make sense in that context. The second describes a behaviour for turning those completions into something that the LSP understands. The `Environment` behaviour and implementation is generally useful outside of the context of completions. The completions feature implemented both behaviours in a single `Lexical.Server.CodeIntelligence.Completion.Env`. This commit decouples the env and the builder implementations, moving the environment-related code (and struct) to `Lexical.Ast.Env` and putting the builder implementation in `Lexical.Server.CodeIntelligence.Completion.Builder`.
`Lexical.RemoteControl.CodeMod.Ast` contained generally-useful functions for parsing and creating zippers from documents. While it was located in `RemoteControl`, it wasn't doing anything that required running on the remote node. Similarly, `Lexical.RemoteControl.CodeMod.Ast.Aliases` contains code for resolving the available aliases at a given position and also has no requirements to run on the remote node. It's been moved to `Lexical.Ast.Aliases`.
This module provided only a relatively thin wrapper over `Aliases.at/2`. It has been moved into `Lexical.Ast`.
This was a comment explaining why position line and character were being incremented when they used to be zero-based. They are now one-based, so this comment is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to extract generally useful existing AST-handling code into
commonso that it can be more easily found and used for other features.I believe this will be most easily reviewed commit-by-commit. Where the changes are not self-evident, I've added explanation to the commit.