Convert utf8->latin1 before decoding JSON-RPC payloads #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This (hopefully) fixes #287. I'm not completely sure why this is occurring, but non-ascii characters were seemingly double-encoded, at least on my system (Ubuntu 22.04 via WSL, VS Code desktop on Windows). I've confirmed with `:io.getopts()` right before `IO.read/2` is called that the encoding is set to `:latin1`, but the result after `JsonRpc.decode/1` was that text would be utf8 double-encoded -- that is, it was what you would expect from: latin1_data |> :unicode.characters_to_binary(:latin1, :utf8) |> :unicode.characters_to_binary(:latin1, :utf8) This would result in `Document.Line` text containing more bytes than it should, which causes text edits to fail, leading behind random extra bytes. I don't love this "fix" because it feels very much like a band-aid, not addressing whatever the root issue is, but I'd also rather things work in documents containing multi-byte characters.
zachallaun
force-pushed
the
za/issue-287
branch
from
753c64f to
46172f4
Compare
|
I tried it and it seems to fix the Chinese encoding issue and it fixes #171 as well: I can get more people to test it. |
scottming
approved these changes
Sep 2, 2023
scohen
reviewed
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (hopefully) fixes #287.
I'm not completely sure why this is occurring, but non-ascii characters were seemingly double-encoded, at least on my system (Ubuntu 22.04 via WSL, VS Code desktop on Windows). I've confirmed with
:io.getopts()right beforeIO.read/2is called that the encoding is set to:latin1, but the result afterJsonRpc.decode/1was that text would be utf8 double-encoded -- that is, it was what you would expect from:This would result in
Document.Linetext containing more bytes than it should, which causes text edits to fail, leading behind random extra bytes.I don't love this "fix" because it feels very much like a band-aid, not addressing whatever the root issue is, but I'd also rather things work in documents containing multi-byte characters.