Explicitly implement protocol in completion modules #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at the commit that introduced the `Impl` helper (4d1269e), its inclusion is understandable. It replaced a previously existing `Translator` that was doing more heavy lifting, but it's now such a thin layer of abstraction that it does not seem worth hiding the intent, which is implementing `Lexical.Completion.Translatable`. This commit also removes the `__deriving__/3` implementation in for the `Translatable` protocol because it was only used by the now-deleted `Impl` and I don't believe it would likely be used by external implementors of the protocol.
scohen
approved these changes
Sep 22, 2023
|
Whoops. Removed unrelated commit. Will merge once checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the commit that introduced the
Implhelper (4d1269e), its inclusion is understandable. It replaced a previously existingTranslatorthat was doing more heavy lifting, but it's now such a thin layer of abstraction that it does not seem worth hiding the intent, which is implementingLexical.Completion.Translatable.This commit also removes the
__deriving__/3implementation in for theTranslatableprotocol because it was only used by the now-deletedImpland I don't believe it would likely be used by external implementors of the protocol.