Detect version manager the same way in all scripts #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`start_lexical.sh` and `port_wrapper.sh` were using different methods to detect the version manager. `start_lexical.sh` was updated more recently, so I standardized on that. I also refactored the detection function slightly to echo the result instead of setting a global variable, since it was only used in one place and can be easily captured. This should also make it easier to extract this function into a shared utility if we desire. Finally, `start_lexical.sh` wasn't doing anything to start the program in the background in non-detected version manager case. I don't fully understand why this is necessary in the first place, but I added it for consistency.
Blond11516
approved these changes
Sep 25, 2023
scohen
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start_lexical.shandport_wrapper.shwere using different methods to detect the version manager.start_lexical.shwas updated more recently, so I standardized on that.I also refactored the detection function slightly to echo the result instead of setting a global variable, since it was only used in one place and can be easily captured. This should also make it easier to extract this function into a shared utility if we desire.
Finally,
start_lexical.shwasn't doing anything to start the program in the background in non-detected version manager case. I don't fully understand why this is necessary in the first place, but I added it for consistency.