Refactor shell scripts and add Docker-based integration tests #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blond11516
reviewed
Sep 30, 2023
scohen
reviewed
Oct 16, 2023
* Add `bin/activate_version_manager.sh` This script encapsulates detecting, finding, and activating a version manager. Currently asdf and rtx are supported, though more work likely needs to be done to make sure that they can be found/activated in more cases. * Refactor `bin/start_lexical.sh` This script now uses `activate_version_manager.sh` to activate the version manager. It additionally ensures that it exits with an error code if any commands run exit non-zero. * `bin/boot.exs` halts after booting Lexical if `LX_HALT_AFTER_BOOT` is set * Begin using `shellcheck` and `shfmt` for script linting and formatting Both of these tools can be installed using asdf/rtx and have editor support through plugins. CI is not currently enforcing that these be used; we can decide on that later. * Add `integration/` dir and integration tests for booting Lexical Currently, these test system installations of elixir, asdf, and rtx, all using bash and running in a Docker container. I'd like to add tests using different shells (zsh/fish/etc.) at some point as well. These tests are not currently running in CI. That will be added in a later commit.
|
This branch fixes a bug that's currently on main that prevents certain environments using |
zachallaun
changed the title
start_lexical.sh and add Docker-based integration tests
scohen
approved these changes
Oct 17, 2023
Since `RemoteControl` already resolves the correct Elixir executable and sets up the env, there's no need to do additional version manager setup in port_wrapper.sh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/activate_version_manager.shThis script encapsulates detecting, finding, and activating a version manager. Currently asdf and rtx are supported, though more work likely needs to be done to make sure that they can be found/activated in more cases.
bin/start_lexical.shThis script now uses
activate_version_manager.shto activate the version manager. It additionally ensures that it exits with an error code if any commands run exit non-zero.bin/boot.exshalts after booting Lexical ifLX_HALT_AFTER_BOOTis setBegin using
shellcheckandshfmtfor script linting and formattingBoth of these tools can be installed using asdf/rtx and have editor support through plugins. CI is not currently enforcing that these be used; we can decide on that later.
integration/dir and integration tests for booting LexicalCurrently, these test system installations of elixir, asdf, and rtx, all using bash and running in a Docker container. I'd like to add tests using different shells (zsh/fish/etc.) at some point as well.
These tests are not currently running in CI. That will be added in a later commit.