Added percentage based progress reporters #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought it would be nicer to have the indexer report its progress in terms of percentage completion rather than jamming a bunch of file names in your face. This change introduces a different funtion for percentage based progress reporting in both remote_control and server. You initialize it with the maximum value for th progress, and then update progress via a updater function that's passed into the callback you give to `with_percent_progress`.
|
@zachallaun @scottming ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it would be nicer to have the indexer report its progress in terms of percentage completion rather than jamming a bunch of file names in your face.
This change introduces a different funtion for percentage based progress reporting in both remote_control and server. You initialize it with the maximum value for th progress, and then update progress via a updater function that's passed into the callback you give to
with_percent_progress.