Added reindex command #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottming
reviewed
Dec 16, 2023
|
Is there a reason not to use the LSP's Execute Command functionality? We can share known commands with server capabilities on initialize. https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_executeCommand |
|
My apologies: I see we are doing this. The code lens is just a convenient interface to trigger it. |
zachallaun
reviewed
Dec 16, 2023
apps/remote_control/lib/lexical/remote_control/commands/reindex.ex
Outdated
Show resolved
Hide resolved
my understanding is that the only two ways to use that functionality are code actions and code lenses. |
scohen
force-pushed
the
reindex-command
branch
from
0e36eb9 to
9ba0325
Compare
scottming
approved these changes
Dec 22, 2023
zachallaun
approved these changes
Dec 22, 2023
Added a reindex code lens so we can rebuild indexes without resorting to manual operations. As we build the indexing infrastructure out, we'll likely need to rebuild the index a lot. Presently, this means restarting the server, which can take some time, so I thought i'd add a command to do it instead. I tried using code actions, but this was a bit fraught, so instead, I used a code lens on the project definition in your mix.exs file.
* Emit a more detailed reason for indexing failures * Added more unit tests for when code lenses should appear
Server originated requests now have improved ergonomics and support requests with no params
scohen
force-pushed
the
reindex-command
branch
from
9ba0325 to
4ac5361
Compare
The code lens now disappears after it's been clicked, and reappears when indexing has completed.
scohen
force-pushed
the
reindex-command
branch
from
4ac5361 to
a3bb0ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a reindex code lens so we can rebuild indexes without resorting to manual operations.
As we build the indexing infrastructure out, we'll likely need to rebuild the index a lot. Presently, this means restarting the server, which can take some time, so I thought i'd add a command to do it instead. I tried using code actions, but this was a bit fraught, so instead, I used a code lens on the project definition in your mix.exs file.
Fixes #517