Replaced refs with snowflakes #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite my idea of creating refs to represent IDs of syntactic elements, they are not globally unique, and can be reused when the VM restarts. This makes them inappropriate for long-lived ids, like we need in the index. I've replaced them with snowflakes, which i benchmarked at 800k qps, are unique, and also represent the time they were created, which means we'll not need to store dates in the index. After the change, lexical's index was 50 MB smaller.
scohen
force-pushed
the
snowflakes_as_ids
branch
from
7df21dc to
756d0a4
Compare
scottming
approved these changes
Jan 3, 2024
I've used this library before, it's fast, it's correct and it's done. Worst case, we fork it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite my idea of creating refs to represent IDs of syntactic elements, they are not globally unique, and can be reused when the VM restarts. This makes them inappropriate for long-lived ids, like we need in the index.
I've replaced them with snowflakes, which i benchmarked at 800k qps, are unique, and also represent the time they were created, which means we'll not need to store dates in the index. After the change, lexical's index was 50 MB smaller.