Implemented find references for module attributes #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scohen
force-pushed
the
module-attributes
branch
from
dadced5 to
a1de5ef
Compare
zachallaun
approved these changes
Jan 18, 2024
apps/remote_control/lib/lexical/remote_control/code_intelligence/entity.ex
Outdated
Show resolved
Hide resolved
apps/remote_control/lib/lexical/remote_control/code_intelligence/entity.ex
Outdated
Show resolved
Hide resolved
apps/remote_control/lib/lexical/remote_control/search/indexer/extractors/module_attribute.ex
Outdated
Show resolved
Hide resolved
apps/remote_control/lib/lexical/remote_control/search/indexer/extractors/module_attribute.ex
Outdated
Show resolved
Hide resolved
apps/remote_control/lib/lexical/remote_control/search/indexer/extractors/module_attribute.ex
Show resolved
Hide resolved
We now index references and usages of module attributes. Saving the module name with the attribute limits its scope to the contained module, which greatly simplifies indexing and search. Fixes #472
scohen
force-pushed
the
module-attributes
branch
from
19b460d to
2003e20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now index references and usages of module attributes. Saving the module name with the attribute limits its scope to the contained module, which greatly simplifies indexing and search.
Fixes #472