For module definitions, use the Indexer version instead of ElixirSense
#658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottming
force-pushed
the
module-definition
branch
from
2cbc91d to
37b7eef
Compare
scottming
commented
Mar 25, 2024
apps/server/lib/lexical/server/provider/handlers/go_to_definition.ex
Outdated
Show resolved
Hide resolved
scohen
reviewed
Mar 26, 2024
apps/remote_control/lib/lexical/remote_control/code_intelligence/definition.ex
Show resolved
Hide resolved
apps/remote_control/lib/lexical/remote_control/code_intelligence/definition.ex
Outdated
Show resolved
Hide resolved
scottming
force-pushed
the
module-definition
branch
from
37b7eef to
f1b1122
Compare
scohen
reviewed
Apr 1, 2024
apps/remote_control/lib/lexical/remote_control/code_intelligence/definition.ex
Outdated
Show resolved
Hide resolved
scottming
force-pushed
the
module-definition
branch
from
f1b1122 to
4087ca0
Compare
scohen
reviewed
Apr 4, 2024
apps/remote_control/test/lexical/remote_control/code_intelligence/definition_test.exs
Outdated
Show resolved
Hide resolved
scohen
reviewed
Apr 5, 2024
apps/remote_control/test/lexical/remote_control/code_intelligence/definition_test.exs
Outdated
Show resolved
Hide resolved
scohen
reviewed
Apr 8, 2024
apps/server/test/lexical/server/provider/handlers/go_to_definition_test.exs
Show resolved
Hide resolved
scohen
reviewed
Apr 9, 2024
apps/remote_control/lib/lexical/remote_control/code_intelligence/definition.ex
Outdated
Show resolved
Hide resolved
scohen
reviewed
Apr 11, 2024
apps/remote_control/lib/lexical/remote_control/code_intelligence/definition.ex
Outdated
Show resolved
Hide resolved
scohen
approved these changes
Apr 11, 2024
|
It's approved, you can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #649