Code Action: Remove unused aliases #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scohen
force-pushed
the
remove-unused-alias
branch
from
93834ac to
88744c5
Compare
zachallaun
reviewed
May 23, 2024
apps/remote_control/lib/lexical/remote_control/code_action/handlers/remove_unused_alias.ex
Outdated
Show resolved
Hide resolved
zachallaun
reviewed
May 23, 2024
apps/remote_control/lib/lexical/remote_control/code_action/handlers/remove_unused_alias.ex
Outdated
Show resolved
Hide resolved
scohen
force-pushed
the
remove-unused-alias
branch
from
2a8ed99 to
fe7f9aa
Compare
scohen
force-pushed
the
remove-unused-alias
branch
from
8fb9622 to
4538142
Compare
This code action removes any unused aliases. It handles both single aliases where it deletes the entire line up to the next line, and multiple aliases, where it deletes the single alias in the list, handling edge cases when it deletes both the last entry in the list, deleting the previous line's comma and when there's only one entry in the list when it deletes the whole alias. The approach here is much more complicated than I wanted, I described the reasons why it's that way in the module's documentation, hopefully, we can get a fix from sourceror soon and improve this.
* Handled removing aliases defined with as: * Only remove aliases on the line that contains the cursor
scohen
force-pushed
the
remove-unused-alias
branch
from
4538142 to
e11b299
Compare
scottming
pushed a commit
to scottming/lexical
that referenced
this pull request
Jun 1, 2024
* Code Action: Remove unused aliases This code action removes any unused aliases. It handles both single aliases where it deletes the entire line up to the next line, and multiple aliases, where it deletes the single alias in the list, handling edge cases when it deletes both the last entry in the list, deleting the previous line's comma and when there's only one entry in the list when it deletes the whole alias. The approach here is much more complicated than I wanted, I described the reasons why it's that way in the module's documentation, hopefully, we can get a fix from sourceror soon and improve this. * made Ast.contains_position? inclusive, like range, and switched to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code action removes any unused aliases. It handles both single aliases where it deletes the entire line up to the next line, and multiple aliases, where it deletes the single alias in the list, handling edge cases when it deletes both the last entry in the list, deleting the previous line's comma and when there's only one entry in the list when it deletes the whole alias.
The approach here is much more complicated than I wanted, I described the reasons why it's that way in the module's documentation, hopefully, we can get a fix from sourceror soon and improve this.