-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Split WebSocket support into separate sync/async implementations #449
Conversation
Looks good, please let me know when the PR is ready for review. |
Should be ready! |
Could you please update the websocket section on README and the websocket examples in |
Done |
LGTM, I will have a few trivial API adjustment and merge. |
on_error=on_error, | ||
ws = await s.ws_connect("wss://api.gemini.com/v1/marketdata/BTCUSD") | ||
print( | ||
"For websockets, you need to set $wss_proxy environment variable!\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dolfies could you please elaborate on $wss_proxy
? It's not mentioned anywhere in the codebase, does it get picked up by underlying curl? What proxies can I use?
This is a continuation of #206, which went stale after I got quite busy. Addresses #202 WebSocket requests (fixes #202, fixes #270).
CurlOpt.CONNECT_ONLY
value, so the session becomes useless if a WebSocket is created from it