Configuration option user_id_claim doesn't work as described in deprecation message.

[b3k]

Using user_identity_field in configuration generates depreacted notification:

The "%path%.%user_identity_field%" configuration key is deprecated since version 2.16, use "%path%.user_id_claim" or implement "' . UserInterface::class . '::getUserIdentifier()" instead.

But using user_id_claim will not behave as we expect when using value other than username, the method JWTManager::addUserIdentityToPayload will always consider values from user_identity_field (as default value which is username).

    protected function addUserIdentityToPayload(UserInterface $user, array &$payload)
    {
        $accessor = PropertyAccess::createPropertyAccessor();

        if ($user instanceof InMemoryUser && ('username' === $this->userIdClaim || 'username' === $this->userIdentityField)) {
            $payload[$this->userIdClaim ?: $this->userIdentityField] = $accessor->getValue($user, 'userIdentifier');

            return;
        }

        $payload[$this->userIdClaim ?: $this->userIdentityField] = $accessor->getValue($user, $accessor->isReadable($user, $this->userIdentityField) ? $this->userIdentityField : 'user_identifier');
    }

So if we have configuration like this:

lexik_jwt_authentication:
    # ...
    user_id_claim:    id

Then last line will be evaulated like this:

$payload['id'] = $accessor->getValue($user, $accessor->isReadable($user, 'username') ? 'username' : 'user_identifier');
// which will give `username` if property is readable

Instead it should first consider $this->userIdClaim field first and then try to access field using $this->userIdentityField.

So in my opinion this should behave maybe like this:

$valueFiled = $this->userIdClaim ?: $this->userIdentityField;
$payload[$valueFiled] = 
    $accessor->getValue($user, $accessor->isReadable($user, $valueFiled) ? $valueFiled : 'user_identifier');

[koftikes]

Hello, all. I pushed MR for fix this issue.