Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New JWTAuthenticator::start method requires hard return type of JWTAuthenticationFailureResponse #904

Closed
aurimasniekis opened this issue Aug 14, 2021 · 0 comments · Fixed by #905

Comments

@aurimasniekis
Copy link
Contributor

aurimasniekis commented Aug 14, 2021

The new Symfony 5.3 JWTAuthenticator::start method has the return type of JWTAuthenticationFailureResponse when the event and all other methods require Symfony Response object. This breaks if your event subscribers set custom responses.

public function start(Request $request, AuthenticationException $authException = null): JWTAuthenticationFailureResponse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant