Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed JWTAuthenticator::start method return type to more generic Response type #905

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

aurimasniekis
Copy link
Contributor

@aurimasniekis aurimasniekis commented Aug 14, 2021

Not a big change just fixes an issue where the old code is upgraded to use the new JWTAuthenticator.

This fixes #904

@aurimasniekis aurimasniekis changed the title Changed JWTAuthenticator::start method return type to more generic Response` type Changed JWTAuthenticator::start method return type to more generic Response type Aug 14, 2021
@aurimasniekis
Copy link
Contributor Author

I am not sure about5.4@devbuild, I don't really see how is it related to my change.

@chalasr
Copy link
Collaborator

chalasr commented Aug 15, 2021

Don’t worry about it, it’s not related

@chalasr
Copy link
Collaborator

chalasr commented Aug 23, 2021

Thanks for fixing this bug @aurimasniekis.

@chalasr chalasr merged commit adfcb5b into lexik:2.x Aug 23, 2021
@aurimasniekis aurimasniekis deleted the aurimasniekis-patch-1 branch August 23, 2021 21:29
@fd6130
Copy link

fd6130 commented Sep 13, 2021

Just encounter this issue on today. I think this patch should be release as soon as possible otherwise it breaks current project that have custom response after upgrade.

How do you think? @chalasr

@chalasr
Copy link
Collaborator

chalasr commented Sep 14, 2021

Thanks for the ping! I will draft the release tonight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New JWTAuthenticator::start method requires hard return type of JWTAuthenticationFailureResponse
3 participants