Added ability to throw exceptions for handling later and to disable the catch-all entry point #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he catch-all entry point
|
Very nice ! Could you update the README ? |
|
I updated the README. |
|
Great, thanks. |
slashfan
pushed a commit
that referenced
this pull request
May 16, 2014
Added ability to throw exceptions for handling later and to disable the catch-all entry point
chalasr
added a commit
that referenced
this pull request
Dec 14, 2023
…figuration (Julius Böllmann)
This PR was merged into the 2.x branch.
Discussion
----------
Wrong type exception for AccessTokenLoader with certain configuration
If I use the feature "webtoken" with that bundle than the following configuration (only signing jwk but not encrypting), leads to an exception when the Encoder is loader and Dependencies are injected.
```
lexik_jwt_authentication:
public_key: '%env(resolve:JWT_PUBLIC_KEY)%'
encoder:
service: lexik_jwt_authentication.encoder.web_token
access_token_issuance:
enabled: true
signature:
algorithm: EdDSA
key: '%env(SIGNATURE_KEY)%'
access_token_verification:
enabled: true
signature:
allowed_algorithms:
- EdDSA
keyset: '%env(SIGNATURE_VERIFICATION_KEYSET)%'
```
The problem in my opinion is the default xml Service configuration, that does not specify the right type. If one acitvates encryption this error disappears as than this config is overwritten anyhow.
```
In AccessTokenLoader.php line 38:
Lexik\Bundle\JWTAuthenticationBundle\Services\WebToken\AccessTokenLoader::__construct(): Argument #10 ($jweHeaderChecker) must be of type ?array, string given, called in /var/www/html/var/cache/test/Container1K8ziZx/getLexikJwtAuthentication_AccessTokenLoaderService.php on line 29
```
Commits
-------
696f600 fix: types for di container for access token loader changed to array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request does not change any behaviours by default, but it does allow you to have the listener throw exceptions instead of handling the response.
This is useful when using FOSRestBundle which has a much more comprehensive exception controller. It handles setting the correct exception code and in the dev environment shows things such as stack traces. More info is here: https://github.com/FriendsOfSymfony/FOSRestBundle/blob/master/Resources/doc/4-exception-controller-support.md and here an example of the listener: https://github.com/FriendsOfSymfony/FOSRestBundle/blob/master/EventListener/AccessDeniedListener.php
For the same reason, the entry point is not required as this bundle can handle setting the correct response code and message.
The simple config for activating these changes it is: