Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ECDSA algo names in LcobucciJWSProvider #1015

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

ControlAltBen
Copy link

Hi,

While trying to use ECDSA signature, I encountered The algorithm "ES256" is not supported by Lexik\Bundle\JWTAuthenticationBundle\Services\JWSProvider\LcobucciJWSProvider.

This name mismatch is pretty clear observing the GenerateKeyPairCommand command, which defines ES256, ES384 and ES512 in its ACCEPTED_ALGORITHMS constant.

This PR fixes this issue and allows usage of ESxxx algorithms.

@chalasr
Copy link
Collaborator

chalasr commented Apr 26, 2022

Nice catch!

@chalasr
Copy link
Collaborator

chalasr commented Apr 26, 2022

Thank you @ControlAltBen.

@chalasr chalasr merged commit 5ef8b77 into lexik:2.x Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants