Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lexik#944: Separate CompatFailureResponse from FailureResponse #1019

Merged
merged 1 commit into from
May 23, 2022

Conversation

GErpeldinger
Copy link
Contributor

@GErpeldinger GErpeldinger commented May 3, 2022

Hello,

Following ondrejmirtes' feedback on issue #944, here is a little fix that might do the trick.

It seems that just separating the classes is not enough for psalm, and that you have to blow up the eval(), which doesn't seem to me to bring any particular difficulty?

update: Oh my bad, it makes the tests fail in 7.1 & 7.4

Copy link
Collaborator

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a great contribution. Thank you very much for tracking down this bug and fixing it.

@GErpeldinger
Copy link
Contributor Author

GErpeldinger commented May 5, 2022

I changed the && to AND until the problem is solved on psalm side.

@chalasr
Copy link
Collaborator

chalasr commented May 23, 2022

Thank you @GErpeldinger.

@chalasr chalasr merged commit 1dc56e9 into lexik:2.x May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants