Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow_no_expiration option to allow validating tokens without ttl #1020

Merged
merged 1 commit into from
May 23, 2022

Conversation

pluk77
Copy link
Contributor

@pluk77 pluk77 commented May 4, 2022

Fresh pull request to fix issue #889

@chalasr
Copy link
Collaborator

chalasr commented May 6, 2022

Looks good to me :) I may change the option name as it looks slightly complicated, but I'm ok with the implementation.
Thank you!

@pluk77
Copy link
Contributor Author

pluk77 commented May 19, 2022

Hello @chalasr . Any idea yet when you plan on approving or incorporating this PR into a new release?

@chalasr chalasr changed the title Only validate expiration date of incoming token if token_ttl is set Add allow_no_expiration option to allow validate tokens without ttl May 21, 2022
@chalasr chalasr changed the title Add allow_no_expiration option to allow validate tokens without ttl Add allow_no_expiration option to allow validating tokens without ttl May 21, 2022
@chalasr
Copy link
Collaborator

chalasr commented May 23, 2022

Thank you @pluk77.

@chalasr chalasr merged commit 567c022 into lexik:2.x May 23, 2022
@pluk77
Copy link
Contributor Author

pluk77 commented May 24, 2022

Thank you so much! This really helps my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants