feat: try to invalidate realpath cache if keypair loading failed #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Jul 16, 2022
|
Thanks for your approval @chalasr. Do you plan to merge it soon? |
lobodol
commented
Jul 26, 2022
| @@ -51,7 +51,17 @@ public function getAdditionalPublicKeys(): array | |||
| throw new \RuntimeException(sprintf('Additional public key "%s" does not exist or is not readable. Did you correctly set the "lexik_jwt_authentication.additional_public_keys" configuration key?', $key)); | |||
| } | |||
|
|
|||
| $contents[] = is_file($key) ? file_get_contents($key) : $key; | |||
| if (is_file($key)) { | |||
There was a problem hiding this comment.
The right part of the ternary expression is missing in this refactoring. Add an else statement:
if (is_file($key)) {
//...
} else {
$contents[] = $key;
}
There was a problem hiding this comment.
Indeed, can you please update the patch?
There was a problem hiding this comment.
Oh crap, some tests seem broken. This is weird, tests pass on my local.
There was a problem hiding this comment.
No worries, it's not related to this change :)
|
Thank you @lobodol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1045