Fixes TypeError in JWTManager #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magikid
force-pushed
the
magikid-1066
branch
from
57719ce to
0591806
Compare
chalasr
reviewed
Sep 6, 2022
When the TokenExtractor extracts a token, it will return `string|false`. The JWTAuthenticator then passes this value to `JWTManager::doAuthenticate` which can only accept a string. If a false is returned by the TokenExtractor, PHP throws a type error. This commit checks the return value and throws an exception if it returns false. Issue: lexik#1066
magikid
force-pushed
the
magikid-1066
branch
from
0591806 to
f80e907
Compare
chalasr
reviewed
Oct 9, 2022
|
Thank you @magikid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the TokenExtractor extracts a token, it will return
string|false. The JWTAuthenticator then passes this value toJWTManager::doAuthenticatewhich can only accept a string. If a falseis returned by the TokenExtractor, PHP throws a type error. This commit
checks the return value and throws an exception if it returns false.
Issue: #1066