Updated to newest namshi/jose. Dropped support for PHP 5.3 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
PHP 5.4 is not supported anymore, you can drop it too. |
|
Unsupported, but still used on many servers, so I will be carefull with this one (it's best to stick with lowest feasible version). |
|
👍 |
1 similar comment
|
👍 |
|
Hi @TiS sorry for the delay, could you update the PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated namsho version to allow newer phpseclib.
All of the phpunit tests passed, so I guess it's fine.
This drops the support of PHP 5.3, but I think it's worth it, as more and more libraries use phpseclib 2.0. This resolves conflicts eg with newest google API client library.