Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lcobucci/jwt v5 #1125

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Allow lcobucci/jwt v5 #1125

merged 1 commit into from
Apr 1, 2023

Conversation

maxhelias
Copy link
Contributor

No description provided.

@maxhelias
Copy link
Contributor Author

Humm lcobucci/jwt need php:^8; Maybe we can do this for version 3?

@chalasr
Copy link
Collaborator

chalasr commented Mar 3, 2023

How hard is it to support both v3 and v5? Ideally we'd let composer do its resolution job

@maxhelias maxhelias force-pushed the lcobucci-v5 branch 3 times, most recently from f43ac9f to b18129e Compare March 3, 2023 09:55
@maxhelias maxhelias changed the title Drop lcobucci/jwt v3 & allow v5 Allow lcobucci/jwt v5 Mar 3, 2023
@maxhelias
Copy link
Contributor Author

@chalasr Actually, no, it's okay 😅

@chalasr
Copy link
Collaborator

chalasr commented Mar 4, 2023

Awesome!

@chalasr
Copy link
Collaborator

chalasr commented Apr 1, 2023

Thank you @maxhelias.

@chalasr chalasr merged commit 099e98c into lexik:2.x Apr 1, 2023
@maxhelias maxhelias deleted the lcobucci-v5 branch April 1, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants