[GHA] Infra & build updates #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
ci-updates
branch
2 times, most recently
from
fb660f2
to
1eabb00
Compare
theofidry
reviewed
Dec 5, 2023
| @@ -63,7 +64,7 @@ jobs: | |||
| composer require --dev --no-update web-token/jwt-encryption-algorithm-aesgcmkw:"^3.0.6" | |||
|
|
|||
| - name: "Install dependencies" | |||
| run: "composer update ${{ matrix.composer-flags }} --prefer-dist" | |||
| run: "composer update ${{ matrix.composer-flags }} --prefer-dist --prefer-stable" | |||
There was a problem hiding this comment.
I would recommend to use ramsey/composer-install for caching. It also removes the need of --prefer-dist --prefer-stable and then doing --prefer-lowest or not is defined by with-dependencies: highest|lowest
There was a problem hiding this comment.
You might need to put SYMFONY_REQUIRE as an environment variable though, but you can do so like that:
- name: Configure the Symfony version
run: echo "SYMFONY_REQUIRE=${{ matrix.symfony }}" >> $GITHUB_ENV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.