Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ci 3x #1214

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Fix ci 3x #1214

merged 2 commits into from
Mar 24, 2024

Conversation

Spomky
Copy link
Contributor

@Spomky Spomky commented Mar 23, 2024

Base on #1201
/cc @chalasr

@Spomky
Copy link
Contributor Author

Spomky commented Mar 23, 2024

I spotted deprecation inconstistencies I need to fix first.
Stay tuned.

@Spomky
Copy link
Contributor Author

Spomky commented Mar 23, 2024

Looks good now.
Tests pass and no direct deprecation notices.

@chalasr
Copy link
Collaborator

chalasr commented Mar 23, 2024

Whoop whoop 🙌 Thanks!

@chalasr
Copy link
Collaborator

chalasr commented Mar 24, 2024

Thanks a lot @Spomky!

@chalasr chalasr merged commit 1feafe2 into lexik:3.x Mar 24, 2024
6 checks passed
@chalasr chalasr mentioned this pull request Mar 24, 2024
Closed
@NeuralClone NeuralClone mentioned this pull request May 22, 2024
Open
@NeuralClone NeuralClone mentioned this pull request Jun 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Spomky @chalasr