Add response message in case of invalid token #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
changed the title
chalasr
changed the title
|
Hi @chalasr it's a good idea if it fixes the the bad token and empty response issue. Could you update the tests or add new ones for this features ? |
|
Hi @slashfan. No problem for the tests, I think verifiying only that the response is not empty. I'll add a check in the JWTListenerTest this week, please tell me if you have more insight or if it's not sufficient. I be back when it's done. |
Use short array syntax + fix cs Update JWTListenerTest to check response on invalid token found Removed useless comment Use Exception message as response message for assertion
|
Hello @slashfan I updated the tests (added a check to see if the response message corresponds to the exception message). |
|
Thanks @chalasr |
slashfan
added a commit
that referenced
this pull request
Mar 14, 2016
Added json response and message in case of invalid token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response of issue #124 , in the JWTListener I replaced the Response by a JsonResponse (such as done by the AuthenticationFailureHandler) but using the exception's message.
The result is that when the token is found but invalid, the following response is returned :
{ "code": 401, "message": "Invalid JWT Token" }Instead of an empty response as it's done currently.
If this makes sense, I can adapt the JWTListenerTest to check the behavior in this specific case (invalid token).