Add OpenSSLKeyLoader #154
Merged
Add OpenSSLKeyLoader #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
referenced
this pull request
Apr 1, 2016
…d_not_be_required Made the public and private key paths not required…
chalasr
force-pushed
the
patch_openssl-checks
branch
2 times, most recently
from
fc2e789
to
996e341
Compare
chalasr
force-pushed
the
patch_openssl-checks
branch
7 times, most recently
from
560e939
to
8f43677
Compare
|
Good idea @chalasr ! Thanks ! |
|
Do you think you could add some tests for the OpenSSLKeyLoader class ? |
|
@slashfan Yes of course, I just realize that I forgotten them. I tell you when it's ok. |
Improve checks for keys and their corresponding exception messages. Move them in a trait used in both Encoder\JWTEncoder and Command\CheckOpenSSLCommand. Avoid duplicated code and make bundle configuration easier to debug Optimize trait methods & their usage in JWTEncoder Replace trait by a OpenSSLKeyLoader service Fix phpdoc Fix phpdoc & typo Improve code quality Fix bad property name Fix undeclared property Spacing Add OpenSSLKeyLoaderTest
chalasr
force-pushed
the
patch_openssl-checks
branch
from
fd9262e
to
12c9973
Compare
|
@slashfan Unit tests added ! |
|
Great ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a service that loads keys from parameters (key paths and passphrase as arguments of the service).
The service has been injected in the JWTEncoder rather than the 3 parameters, same for the method
checkOpenSSLConfigthat has been moved in the service and now takes no argument.This also Improve checks for keys and their corresponding exception messages (One for file existing/reading problem, one for openssl loading, this for both public and private keys).
This avoid duplicated code (Command & Encoder) and make the bundle configuration easier to debug (centralised key loading logic).