Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Symfony versions < 2.8 from travis.yml #167

Merged
merged 1 commit into from
May 13, 2016

Conversation

chalasr
Copy link
Collaborator

@chalasr chalasr commented May 10, 2016

After discussed in #132, we stop supporting Symfony versions lower than 2.8 for the branch 2.0 and 2.x releases of this bundle, and so stop ensuring compatibility with these Symfony versions on travis-ci .

Open to any suggestion (missing version, specific php version for specific symfony one, ...).

@slashfan
Copy link
Contributor

We should remove PHP5.4 reference and also test against PHP 5.5, I know it's dead but this is Symfony 3.0 and current namshi/jose minimal PHP version requirement.

@chalasr
Copy link
Collaborator Author

chalasr commented May 11, 2016

Don't you think that we should ensure compatibility with (almost) the minimal PHP version required by Symfony 2,8? It requires 5.3.9 so 5.4 could be a good compromise, plus the 5.4 release given lots of new features.

Otherwise no problem, I'll remove it.

@slashfan
Copy link
Contributor

OK, we can keep PHP 5.4 compatibility since we do not directly use specific PHP 5.5+ features at the moment (athough namshi/jose library currently requires 5.5+ so there might be a conflict during a composer install). But PHP 5.3 is way too old to be taken care of anymore.

@chalasr
Copy link
Collaborator Author

chalasr commented May 12, 2016

@slashfan Did I miss something or is it ok for this one?

@slashfan
Copy link
Contributor

@chalasr OK for me

@slashfan slashfan merged commit ec1ddbf into lexik:2.0 May 13, 2016
@chalasr chalasr deleted the patch_travis_2.x branch May 14, 2016 11:53
@chalasr
Copy link
Collaborator Author

chalasr commented May 15, 2016

@slashfan You were right, 5.5 introduced interesting features such as ClassName::class to get a FQCN.
I'll remove 5.4 form travis config and make the bundle requiring php 5.5.
Is it ok for you?

@slashfan
Copy link
Contributor

👍 for me

This was referenced May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants