Add JWTAuthenticationResponse #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CS Fixes [WIP] Use the JWTResponse in authentication handlers Add authentication failure/success Response classes Fix tests
|
ping @slashfan |
|
OK for me, I was just waiting for the last checkbox to be checked |
|
I was waiting your opinion about the feature before writing the doc :) I ping you when it's done |
chalasr
force-pushed
the
jwt_response
branch
3 times, most recently
from
2f2ee10
to
55b5c22
Compare
|
@slashfan Doc slightly updated, ready to review. No changed typehint and no difference in events that developers listen on, no BC break. |
| */ | ||
| public function setMessage($message) | ||
| { | ||
| $this->message = $message; |
There was a problem hiding this comment.
Is it expected that the JSON body keep the initial message when the message is modified ?
There was a problem hiding this comment.
Good catch @GromNaN
Scrutinizer Fixes Fix segmentation fault (infinite loop) BTW fix deprecation warning if funct test config Fixed setData logic in success+failure responses Add a JWTAuthenticationFailureTest::testSetMessage
|
👍 |
chalasr
added a commit
to chalasr/LexikJWTAuthenticationBundle
that referenced
this pull request
Jun 22, 2016
| Q | A | |---------------|------| | Bug fix? | no | | New feature? | yes | | BC breaks? | no | | Deprecations | yes | | Fixed tickets | n/a | | Tests pass? | yes | This introduces a generic Response class for successful/failed authentication. BTW remove duplicated failure Responses with pretty much the same data (3times). Let me know what do you think. Steps: - [x] Add JWTAuthenticationFailureResponse & JWTAuthenticationSuccessResponses - [x] Add tests - [x] Update documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a generic Response class for successful/failed authentication.
BTW remove duplicated failure Responses with pretty much the same data (3times).
Let me know what do you think.
Steps: