[DX] Add JWTNotFoundEvent #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
jwt_not_found_event
branch
from
da7d8f7
to
2bc971a
Compare
chalasr
force-pushed
the
jwt_not_found_event
branch
from
fa50956
to
6d0a31e
Compare
chalasr
force-pushed
the
jwt_not_found_event
branch
from
6d0a31e
to
8ed8d31
Compare
Add JWTNotFoundEvent Add JWTFailureEventInterface implemented by both JWTNotFoundEvent and JWTInvalidEvent Dispatch the JWTNotFound when no token is found in the request (from JWTListener) Tests that the good event is dispatched in JWTListenerTest Add documentation Fix bad description in Events::JWT_NOT_FOUND Fix typos in documentation
chalasr
force-pushed
the
jwt_not_found_event
branch
from
8ed8d31
to
dbdcf65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the fixed tickets,, I propose to add a specific
JWT_NOT_FOUND, making users able to catch this event and set a custom response if they want, or just ignore it.It can be useful to secure routes that are part of anonymous firewalls, for restrict it to a specific user role for instance, or just have the same behaviour as on
JWT_INVALID.Also it introduces an interface implemented by both
JWT_NOT_FOUNDandJWT_INVALID, so the same (listener) method can be used to listen on both events.Closes #187.