[Configuration] Make *_key_path config options not mandatory #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
optional_key_path
branch
from
70fe892 to
37b9c50
Compare
chalasr
force-pushed
the
optional_key_path
branch
5 times, most recently
from
367ac72 to
6688189
Compare
Logic fixes Make getKeyValidator private and static Rename getKeyValidator to validateKeyPath
chalasr
force-pushed
the
optional_key_path
branch
from
6688189 to
be41ce0
Compare
|
Looks good. |
|
Thank you for reviewing it.
I hesitated to remove this additional check and I understand it doesn't feel relevant, but I thought it is preferable to keep it, in order to prevent the case of this value is overridden by the end user or some other edge cases of this kind. WDYT? |
|
OK it makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we want to integrate different bridges of JW* libraries, the
*_key_pathoptions should not be mandatory anymore, because some of their libraries (especially https://github.com/spomky-labs/lexik-jose-bridge) doesn't need this to be configured.@Spomky, you worked on this in #195 (partially), sorry for that, we will profit of this change to perform some checks (key files existence) via config validation. Let me know what do you think.