Depreciate injection of Request instances #200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depreciates the injection of
Request
instances in order to totally avoid this practice in 2.0. That concerns most of our Event classes.Warning triggered by Scrutinizer:
The proposed deprecation way consists into:
Request
(BC break)E_USER_DEPRECATED
notice when the deprecated methods are called with a Request as argument.The recommended alternative is to inject the RequestStack instead.
For
Event
classes, the user will be responsible of injecting the request stack into their event listeners to be able to use it.All changed classes are instantiated internally, I think this should not be an hard BC breaking for most people.
Any thoughts?
@request_stack
injection&usage