Remove deprecated request args #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function __construct(JWTEncoderInterface $encoder, EventDispatcherInterface $dispatcher, RequestStack $requestStack, $ttl) |
There was a problem hiding this comment.
One less BC break but a big new one.
chalasr
force-pushed
the
remove_deprecated_request_args
branch
2 times, most recently
from
0e13d42
to
0122190
Compare
chalasr
force-pushed
the
remove_deprecated_request_args
branch
2 times, most recently
from
11d4069
to
e76ddf0
Compare
9 tasks
chalasr
force-pushed
the
remove_deprecated_request_args
branch
2 times, most recently
from
54c0dfb
to
379eb42
Compare
Remove deprecated Request instances injections Remove usage from our code CS fixes Fix rebase conflicts
chalasr
force-pushed
the
remove_deprecated_request_args
branch
from
379eb42
to
639fb8d
Compare
chalasr
added a commit
that referenced
this pull request
Jul 29, 2016
chalasr
added a commit
that referenced
this pull request
Jul 29, 2016
| Q | A | ------------- | --- | Branch? | 2.0 | Bug fix | yes | Feature | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes This fixes a big bug introduced in #201 because of an unmerged path (`services.xml`). It caused that a bad value was passed as token ttl, so it is unable to decode any token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This totally remove the ability of injecting request instances in Event classes, plus there is no more need of injecting the
@request_stackservice into theJWTManagerclass.