Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions simplified #202

Merged
merged 1 commit into from
Jul 21, 2016
Merged

Exceptions simplified #202

merged 1 commit into from
Jul 21, 2016

Conversation

Spomky
Copy link
Contributor

@Spomky Spomky commented Jul 21, 2016

This PR removes some exceptions as they do not add anything except a preset message.
Now only one class is left and should be used on every JWT encoding/decoding error.

@chalasr
Copy link
Collaborator

chalasr commented Jul 21, 2016

Thank you for that @Spomky 👍 .

One thing though, I would have kept two kind of failures separated, i.e. JWTEncodeFailureException and JWTDecodeFailureException, WDYT?

@Spomky
Copy link
Contributor Author

Spomky commented Jul 21, 2016

This means to have two classes with exactly the same content (except the name of the class).

@chalasr
Copy link
Collaborator

chalasr commented Jul 21, 2016

Not a problem to me, exception classes are often empty, only the name change for a matter of easy catching and clear stack traces.

@Spomky
Copy link
Contributor Author

Spomky commented Jul 21, 2016

OK. I will update that PR

@chalasr chalasr merged commit 7a84f54 into lexik:2.0 Jul 21, 2016
@Spomky Spomky deleted the ExceptionsFactorisation branch July 21, 2016 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants