Introduce a JWTUserProvider allowing to trust in the JWT #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
stateless_user_provider
branch
from
6f1171d
to
c280e11
Compare
chalasr
force-pushed
the
stateless_user_provider
branch
from
c280e11
to
1ee6695
Compare
chalasr
changed the title
chalasr
force-pushed
the
stateless_user_provider
branch
2 times, most recently
from
a5e72e8
to
b9fea51
Compare
chalasr
force-pushed
the
stateless_user_provider
branch
4 times, most recently
from
781173a
to
e65c4bb
Compare
chalasr
force-pushed
the
stateless_user_provider
branch
6 times, most recently
from
e97a048
to
8dfd713
Compare
Rethink test config loading
chalasr
force-pushed
the
stateless_user_provider
branch
from
8dfd713
to
b3a6543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From jwt.io:
This is a working draft at the moment, allowing to preserve the federation benefit of JWT by avoiding fetching the user from the datastore more than once, so each token-authenticated request trusts in the JWT data rather than reloading the user to authenticate it.
I'm not sure how this should be introduced, at first I think it should not be the recommended way to use this bundle, but I do think we should have it since we are signing tokens and verifying them at each request, it makes sense to don't reverify the user.
Closes #277 once finished.
/cc @scaytrase