Avoid validating key paths before container compilation #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @chalasr, I am not sure the spomky-labs/jose-bundle is concerned as there is no path validation in the key configuration. The bundle only creates the key definitions using a dedicated method called by the compiler pass. The path is checked only when the definition is used and the key factory is called. However, I will be happy to know if I am wrong or not a fix it if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #284 by removing key path validation from our configuration since it's too early for stream wrappers. Paths are still checked at runtime on credentials+jwt login.
/cc @Spomky maybe
SpomkyLabs/JoseBundleis concerned by this issue too