feat: Allow for Response Body without JWT Token #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
AlexBachmann
force-pushed
the
remove-body-token
branch
from
5001cea
to
80a18e9
Compare
|
Looking at the tests, I realized, that a better implementation would be to add the token to the response data in the constructor. This brings the implementation closer to the original JsonResponse implementation while preserving the previous behavior. The replaceData Test now checks that the token is really removed, when the data array does not contain the token data. |
chalasr
reviewed
Mar 30, 2017
| @@ -28,18 +28,8 @@ | |||
| */ | |||
| public function __construct($token, array $data = null) | |||
| { | |||
| $this->token = $token; | |||
| $data = is_null($data) ? [] : $data; | |||
There was a problem hiding this comment.
Could $response = null be changed to $response = [] in the signature? It would remove the need for this line
AlexBachmann
force-pushed
the
remove-body-token
branch
from
80a18e9
to
d813ba4
Compare
|
Thank you @Batch1211! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is regarding Issue #313.
My proposed change would not change to current behavior of the bundle. All it does is respecting any changes being made to the response data during the AUTHENTICATION_SUCCESS event. That is, if an event listener decides to remove the token from the data array, it will no longer be added later.