Fix HMAC support #369
Merged
Fix HMAC support #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
lcobucci/fix-hmac-support
branch
from
fa16a77
to
d6667f6
Compare
chalasr
force-pushed
the
lcobucci/fix-hmac-support
branch
2 times, most recently
from
61c9e60
to
72f46ae
Compare
chalasr
force-pushed
the
lcobucci/fix-hmac-support
branch
from
72f46ae
to
fd01950
Compare
chalasr
force-pushed
the
lcobucci/fix-hmac-support
branch
from
fd01950
to
1e80e91
Compare
chalasr
force-pushed
the
lcobucci/fix-hmac-support
branch
2 times, most recently
from
695deaf
to
d8adaed
Compare
chalasr
force-pushed
the
lcobucci/fix-hmac-support
branch
3 times, most recently
from
1195745
to
b01c822
Compare
chalasr
force-pushed
the
lcobucci/fix-hmac-support
branch
3 times, most recently
from
bac2e67
to
4ef2b3f
Compare
|
Any update as to when this could be implemented? |
|
@railto This will be released by the end of the month, some cleanup needed. |
|
@chalasr - Can't wait for this to be implemented. It'll be easier to deploy with docker thanks to this PR. No more volume to store only the keys... |
chalasr
force-pushed
the
lcobucci/fix-hmac-support
branch
from
4ef2b3f
to
83226e6
Compare
Oliboy50
reviewed
Apr 24, 2018
| @@ -25,12 +25,23 @@ public function getConfigTreeBuilder() | |||
| ->addDefaultsIfNotSet() | |||
| ->children() | |||
| ->scalarNode('private_key_path') | |||
| ->setDeprecated('The "%path%.%node%" configuration key is deprecated since version 2.5. Use "%path%.secret_key%" instead.') | |||
There was a problem hiding this comment.
I think the new configuration key should contain 2 or 4 % symbols, not 3, right?
| ->defaultNull() | ||
| ->end() | ||
| ->scalarNode('public_key_path') | ||
| ->setDeprecated('The "%path%.%node%" configuration key is deprecated since version 2.5. Use "%path%.public_key%" instead.') |
This was referenced May 21, 2018
|
@chalasr What is the progress here? Do you need any help? |
chalasr
force-pushed
the
lcobucci/fix-hmac-support
branch
6 times, most recently
from
9448f84
to
d4c4954
Compare
|
Sorry for being latish guys, this is ready and will be merged today (not now in case one wants to give it a last review). |
chalasr
force-pushed
the
lcobucci/fix-hmac-support
branch
from
d4c4954
to
a6a7718
Compare
chalasr
added a commit
that referenced
this pull request
Jun 12, 2018
tbalsys
reviewed
Jun 14, 2018
| $container->setParameter('lexik_jwt_authentication.public_key_path', $config['public_key']); | ||
| } | ||
|
|
||
| if (empty($config['public_key']) && empty(['secret_key'])) { |
There was a problem hiding this comment.
Shouldn't it be empty($config['secret_key'])?
There was a problem hiding this comment.
nice catch! thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #307
Fixes #340