[Feature] clock skew #492
Merged
[Feature] clock skew #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement clock_skew parameter * update unit test
|
Could you also update the |
|
I needed this for a project I'm working on, so why not share the implementation 😄 |
|
Finally had the time for it, also updated the corresponding tests. |
chalasr
approved these changes
Jun 1, 2018
|
Thanks @patrickjDE for working on this feature, this is much appreciated. |
chalasr
added a commit
that referenced
this pull request
Jun 1, 2018
This PR was merged into the 2.x-dev branch. Discussion ---------- [Feature] clock skew * implement clock_skew parameter * update unit test This PR introduces the clock skew parameter, that allows to account for time differences between servers. Commits ------- c0e919a implement clock skew for LcobucciJWSProvider, update unit tests 3efe31d [Feature] clock skew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the clock skew parameter, that allows to account for time differences between servers.