Make openssl key loader service deprecated #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Service OpenSSLKeyLoader is deprecated since version 2.5. It triggers deprecation error as soon as someone tries to include it. Symfony framework tries to create reflection of it while building the container and it triggers deprecation as well. Symfony doesn't know anything about this service being deprecated. Service should be declared as deprecated in service config, then Symfony won't touch it. [lexik#523]
chalasr
approved these changes
Jul 5, 2018
|
Thanks for fixing this bug @faecie. |
chalasr
added a commit
that referenced
this pull request
Jul 5, 2018
This PR was merged into the 2.x-dev branch. Discussion ---------- Make openssl key loader service deprecated Service OpenSSLKeyLoader is deprecated since version 2.5. It triggers deprecation error as soon as someone tries to include it. Symfony framework tries to create reflection of it while building the container and it triggers deprecation as well. Symfony doesn't know anything about this service being deprecated. Service should be declared as deprecated in service config, then Symfony won't touch it. [#523] Commits ------- a115640 Make openssl key loader service deprecated
|
@chalasr Can not find this fix in v2.5.2 |
|
@faecie v2.5.2 is older, v2.5.3 has just been released with this fix. |
|
@chalasr thanks, All sorted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service OpenSSLKeyLoader is deprecated since version 2.5. It triggers
deprecation error as soon as someone tries to include it. Symfony
framework tries to create reflection of it while building the container
and it triggers deprecation as well. Symfony doesn't know anything about this
service being deprecated. Service should be declared as deprecated in
service config, then Symfony won't touch it.
[https://github.com//issues/523]