Customizable User ID Claim #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Aug 10, 2018
| /** | ||
| * @var string | ||
| */ | ||
| protected $userIdClaim; |
There was a problem hiding this comment.
let's make it private to reduce the maintenance cost, it's exposed through a getter
|
Should be fine now. |
|
Thank you @Spomky. |
chalasr
added a commit
that referenced
this pull request
Aug 10, 2018
This PR was squashed before being merged into the 2.x-dev branch (closes #537). Discussion ---------- Customizable User ID Claim This PR modifies the claim used to store the user ID in tokens. Prior this PR, the claim was the same as the `user_entity_field` option (e.g. `username`). Now the user ID claim can be customized to the standard claim `sub` (subject) as per the [RFC7519 section 4.1.2](https://tools.ietf.org/html/rfc7519#section-4.1.2) or any other value (e.g. `user_id`). A new configuration option s added: `user_id_claim`. If null, it will have the same value as `user_entity_field`. This PR also allow a BC with tokens that have already been issued by an application. Commits ------- 0862239 Customizable User ID Claim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the claim used to store the user ID in tokens.
Prior this PR, the claim was the same as the
user_entity_fieldoption (e.g.username).Now the user ID claim can be customized to the standard claim
sub(subject) as per the RFC7519 section 4.1.2 or any other value (e.g.user_id).A new configuration option s added:
user_id_claim. If null, it will have the same value asuser_entity_field.This PR also allow a BC with tokens that have already been issued by an application.