Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing implements breaking JWT header alteration #542

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

tucksaun
Copy link
Contributor

@tucksaun tucksaun commented Aug 2, 2018

Otherwise headers are not get from the event, see

if ($this->jwtEncoder instanceof HeaderAwareJWTEncoderInterface) {
$jwtString = $this->jwtEncoder->encode($jwtCreatedEvent->getData(), $jwtCreatedEvent->getHeader());
} else {
$jwtString = $this->jwtEncoder->encode($jwtCreatedEvent->getData());
}

@chalasr
Copy link
Collaborator

chalasr commented Aug 2, 2018

Good catch, thanks @tucksaun.

@chalasr chalasr merged commit 53755d0 into lexik:master Aug 2, 2018
chalasr added a commit that referenced this pull request Aug 2, 2018
…aun)

This PR was merged into the 2.x-dev branch.

Discussion
----------

Fix missing implements breaking JWT header alteration

Otherwise headers are not get from the event, see  https://github.com/lexik/LexikJWTAuthenticationBundle/blob/85b05784fbad7d6435626915edeeb55ed0bcd6a7/Services/JWTManager.php#L61-L65

Commits
-------

53755d0 Fix missing implements breaking JWT header alteration
@Spomky
Copy link
Contributor

Spomky commented Aug 2, 2018

Excellent.Missed that none when I submitted the PR

@chalasr
Copy link
Collaborator

chalasr commented Aug 2, 2018

Released in v2.5.4

@tucksaun tucksaun deleted the missing-implements branch December 7, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants