Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix argument order in JWTProvider service declaration #577

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Fix argument order in JWTProvider service declaration #577

merged 1 commit into from
Nov 7, 2018

Conversation

fjogeleit
Copy link
Contributor

Fix related to #576

fjogeleit
fjogeleit commented Nov 4, 2018
View reviewed changes
Copy link
Contributor Author

@fjogeleit fjogeleit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you told my why the scrutinizer check is failing? I can't find detailed informations

@fjogeleit fjogeleit changed the title Fix argument order in JWTProvder service declaration Fix argument order in JWTProvider service declaration Nov 6, 2018
@chalasr
Copy link
Collaborator

chalasr commented Nov 7, 2018

Good catch, thanks @fjogeleit.

@chalasr chalasr merged commit 714003d into lexik:master Nov 7, 2018
chalasr added a commit that referenced this pull request Nov 7, 2018
@chalasr
bug #577 Fix argument order in JWTProvider service declaration (fjoge…
0969247 
…leit)

This PR was merged into the 2.x-dev branch.

Discussion
----------

Fix argument order in JWTProvider service declaration

Fix related to #576

Commits
-------

714003d Fix argument order in JWTProvider service declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fjogeleit @chalasr