Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use late static binding on JWTUser #675

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Use late static binding on JWTUser #675

merged 1 commit into from
Aug 2, 2019

Conversation

kaznovac
Copy link
Contributor

use late static binding on JWTUser so I as a developer can extend this class (createFromPayload can now return instance of class extending this class)

https://www.php.net/manual/en/language.oop5.late-static-bindings.php

@chalasr
Copy link
Collaborator

chalasr commented Aug 2, 2019

Good catch, thanks @kaznovac.

@chalasr chalasr merged commit e0d95f4 into lexik:master Aug 2, 2019
chalasr added a commit that referenced this pull request Aug 2, 2019
This PR was squashed before being merged into the 2.x-dev branch (closes #675).

Discussion
----------

Use late static binding on JWTUser

use late static binding on `JWTUser` so I as a developer can extend this class (createFromPayload can now return instance of class extending this class)

https://www.php.net/manual/en/language.oop5.late-static-bindings.php

Commits
-------

e0d95f4 Use late static binding on JWTUser
@kaznovac kaznovac deleted the patch-1 branch August 3, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants