add JWTEncodedEvent so JWT string is available after its creation #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide use cases? |
|
Of course :-) We need to persist JWT so it's possible to check if user's token is valid. To avoid hitting the backend this check will be done from varnish level. So if we want to store JWT string representation we need to know its value when it's created. |
|
Nice addition. Ok for merge. |
slashfan
added a commit
that referenced
this pull request
Jul 8, 2015
add JWTEncodedEvent so JWT string is available after its creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes this is useful (or even essential) to get JWT string right after it is created. This PR introduces new type of event - JWTEncodedEvent which is being dispatched right after JWT is created (encoded) and contains JWT string.