Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against symfony 5.1 and fix deprecations #755

Merged

Conversation

acrobat
Copy link
Contributor

@acrobat acrobat commented May 28, 2020

In order to fix this deprecation I had to bump the minimum supported php version to 5.6.
I don't know what the policy is on supporting php versions, but php 5.5 is EOL for a long time now so I guess this is ok to do?

This pr now fixes also other symfony 5.1 deprecations

@acrobat acrobat force-pushed the fix-symfony-51-setdeprecated-deprecation branch 2 times, most recently from 0bf714a to 831b784 Compare May 28, 2020 14:06
@acrobat acrobat force-pushed the fix-symfony-51-setdeprecated-deprecation branch from 8d65b4d to 93662ed Compare May 31, 2020 08:26
@acrobat acrobat changed the title Fix symfony 5.1 config setDeprecated parameters deprecation Test against symfony 5.1 and fix deprecations May 31, 2020
@acrobat acrobat force-pushed the fix-symfony-51-setdeprecated-deprecation branch from c15b157 to 93662ed Compare May 31, 2020 10:00
@chalasr chalasr force-pushed the fix-symfony-51-setdeprecated-deprecation branch from 93662ed to 4ca47ac Compare May 31, 2020 11:54
@chalasr
Copy link
Collaborator

chalasr commented May 31, 2020

Great! Thank you @acrobat.

@chalasr chalasr merged commit 3074c41 into lexik:master May 31, 2020
@acrobat acrobat deleted the fix-symfony-51-setdeprecated-deprecation branch May 31, 2020 11:57
@acasademont
Copy link

Thanks a lot! Will it be possible to release a patch version soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants